✨ Broker KAI api through hub. #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
pushed a commit
to konveyor/tackle2-ui
that referenced
this pull request
Sep 12, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]>
sjd78
pushed a commit
to sjd78/tackle2-ui
that referenced
this pull request
Sep 12, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
jortel
force-pushed
the
kai-support2
branch
from
fdbc427
to
9c9ae19
Compare
Signed-off-by: Jeff Ortel <[email protected]>
Signed-off-by: Jeff Ortel <[email protected]>
|
Tested with auth enabled. |
aufi
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
LGTM
Please correct me if I'm wrong, in "standard" k8s-based Konveyor installation, there are two proxies to access the kai (UI->Hub, Hub->kai) while Hub cares about authorization. The main reason for that is to be able re-use kai service with inside-IDE instalations?
Exactly. The only purpose of proxying through the hub is to enforce AUTH. |
Shevijacobson
pushed a commit
to Shevijacobson/tackle2-ui
that referenced
this pull request
Sep 18, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]>
Shevijacobson
pushed a commit
to Shevijacobson/tackle2-ui
that referenced
this pull request
Sep 18, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]> Signed-off-by: Shevijacobson <[email protected]>
DvoraShechter1
pushed a commit
to DvoraShechter1/tackle2-ui
that referenced
this pull request
Sep 19, 2024
Related: konveyor/tackle2-hub#750 Signed-off-by: Jeff Ortel <[email protected]>
This was referenced Oct 1, 2024
dymurray
pushed a commit
that referenced
this pull request
Oct 11, 2024
Add `/services/` endpoint. Add `/services/kai/*` endpoint reverse-proxy to route defined in KAI_URL. Add auth scopes. Related: konveyor/operator#376 --------- Signed-off-by: Jeff Ortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
/services/endpoint.Add
/services/kai/*endpoint reverse-proxy to route defined in KAI_URL.Add auth scopes.
Related: konveyor/operator#376