Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Support displaying storage values in base-2 #118

Closed
wants to merge 7 commits into from
Closed

feat(ui): Support displaying storage values in base-2 #118

wants to merge 7 commits into from

Commits on Oct 14, 2022

  1. Add storage value base-10/2 display to ui-preferences

    @sowaret
    sowaret committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    993d28f View commit details
    Browse the repository at this point in the history

  2. Create SizeDisplay component

    @sowaret
    sowaret committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    afabbf7 View commit details
    Browse the repository at this point in the history

  3. Add unit toggle to Table

    @sowaret
    sowaret committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ade0eef View commit details
    Browse the repository at this point in the history

  4. Final cleanup

    @sowaret
    sowaret committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e04d7b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Move sizeWithFailures logic to SizeDisplay 

    A component is used now, so it makes sense to separate the error string
logic from the JSX output

- Add missing `setBytesStringBase2` field to `UIPreferencesContext`
- Update Provider `initialValue` to accept `Partial` (e.g. in test)
- Add tests; add missing base-2 cases in `ui.test.ts`
- Update the empty error string logic from `sizeWithFailures` to check
that all fields are empty:

`if (!summ || !summ.errors || !summ.numFailed)` to
`if (!summ?.errors?.length && !summ?.numFailed)`
    @sowaret
    sowaret committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    a72909e View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Swap toggle for dropdown, add test, remove unused imports

    @sowaret
    sowaret committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    33dc785 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Fix tests and create test context provider

    @sowaret
    sowaret committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d59e9bb View commit details
    Browse the repository at this point in the history