fix(actions): actions are not saved after sanitizeActions() #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method checks for "path" instead of script. Therefore, all actions are set to undefined and are never saved.
|
Hi @jkowalski i've tested it briefly and provided the path to a .bat file. The .bat file was executed on windows. However, currently people are having issues, as their policy contains "path" which is currently not used in 0.13. Cheers, |
jkowalski
approved these changes
Jul 14, 2023
jkowalski
added a commit
to jkowalski/kopia
that referenced
this pull request
Jul 14, 2023
- theming support kopia/htmlui#150 - actions fix kopia/htmlui#163
jkowalski
added a commit
to kopia/kopia
that referenced
this pull request
Jul 14, 2023
* feat(ui): UI updates (Theming support, action fix) - theming support kopia/htmlui#150 - actions fix kopia/htmlui#163 * disable dark mode selector test
|
This might not be the same issue, but I will mention just in case: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR may fix actions not being saved in the policy editor. Debuging the policy editor indicated that the method sanitizeActions(..) checks for "path" instead of script. The policy editor, however, stores the information in "script"
" {ActionRowScript(this, "actions.afterSnapshotRoot.script", "After Snapshot", "Script to run after snapshot")}"
Therefore, all actions are set to undefined and are never saved. The issue was introduced in #133.
This PR may fix kopia/kopia#3046
Feedback is welcomed.
Cheers,