Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fixed error while rendering source table #188

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

lupusA
Copy link
Collaborator

@lupusA lupusA commented Sep 14, 2023

Hi,

This PR is a fix of #186. Setting the state while rendering throws a JS error.
Setting the selectedOwner is now done after the component has been mounted.

The rendering function then just interprets the selectedOwner.

Feedback is welcomed.

Cheers,

@lupusA
Copy link
Collaborator Author

lupusA commented Sep 14, 2023

@jkowalski

Please review and comment if neccessary.

Cheers,

@jkowalski jkowalski merged commit c9bfb46 into kopia:main Sep 14, 2023
2 checks passed
@lupusA lupusA deleted the fix-setting-state-in-rendering branch September 15, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants