Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix for dark theme #191

Merged
merged 2 commits into from
Sep 17, 2023
Merged

fix(ui): Fix for dark theme #191

merged 2 commits into from
Sep 17, 2023

Conversation

lupusA
Copy link
Collaborator

@lupusA lupusA commented Sep 17, 2023

Hi,

this PR should fix the dark theme that is currently in production.

Cheers,

@lupusA
Copy link
Collaborator Author

lupusA commented Sep 17, 2023

Hi @jkowalski,

maybe a rebuilt does it already. I've rebuilt it locally and it seems to work without the PR

image

@ptandler
Copy link
Contributor

Hi @lupusA, is this about this issue in the current v0.14.0? i.e. the wrong colors in the striped table and the missing dark mode in some (all?) input fileds? I was just about to file an issue and then found your PR.

Screenshot_20230917_103540

@lupusA
Copy link
Collaborator Author

lupusA commented Sep 17, 2023

Hi @ptandler,

Yeah it is, but I think it just needs to be rebuild. I was not able to reproduce it with a local new build of htmlui.

For the input fields I am sure that they were also bright in the original version (e.g. policy editor). I checking it again, when I am back.

I think this PR is not necessary.

Cheers,

@lupusA
Copy link
Collaborator Author

lupusA commented Sep 17, 2023

Hi @ptandler,

the input fields need an overhaul for the dark theme. We can use this PR for it.

Cheers

- Changed the brightness of warning color in dark-mode
@lupusA
Copy link
Collaborator Author

lupusA commented Sep 17, 2023

@jkowalski , @ptandler
This is how it should look like:

2023-09-17.130827.mp4

Please test it.

Cheers,

@lupusA lupusA marked this pull request as ready for review September 17, 2023 11:15
@jkowalski jkowalski merged commit 417128d into kopia:main Sep 17, 2023
2 checks passed
jkowalski added a commit to jkowalski/kopia that referenced this pull request Sep 17, 2023
jkowalski added a commit to kopia/kopia that referenced this pull request Sep 17, 2023
@lupusA lupusA deleted the fix-dark-theme branch September 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants