Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Refactoring of themes #193

Merged
merged 10 commits into from
Oct 10, 2023
Merged

Conversation

lupusA
Copy link
Collaborator

@lupusA lupusA commented Sep 18, 2023

Hi,
this PR containes the following changes:

  • Badge colors are now dependend on the theme
  • Badge colors are now more readable

This PR is currently a draft. A further refactoring of the .css styles is necessary.
This PR will close kopia/kopia#3317 and kopia/kopia#3368

Feedback is welcomed.

Cheers,

- Badge colors are now dependend on the theme
@lupusA
Copy link
Collaborator Author

lupusA commented Sep 18, 2023

Here are some screenshots:

Theme: Light
image

Theme: Dark
image

Copy link
Contributor

@jkowalski jkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on visuals. Can't really comment on CSS.

lupusA and others added 4 commits September 27, 2023 18:40
* Fix missing badges in policies

* Childs now have unique key in list

* Added isEmptyObject()

---------

Co-authored-by: Christoph Anderson <[email protected]>
@lupusA lupusA marked this pull request as ready for review September 29, 2023 19:33
@lupusA lupusA marked this pull request as draft September 29, 2023 19:42
@lupusA lupusA marked this pull request as ready for review October 4, 2023 16:53
@lupusA
Copy link
Collaborator Author

lupusA commented Oct 4, 2023

Hi @jkowalski,

the PR is ready for review. I will create another, where we focus on moving to scss.

Cheers,

@lupusA
Copy link
Collaborator Author

lupusA commented Oct 10, 2023

Hi @jkowalski,

can you merge this PR, so that i can check the official build?

Cheers

@jkowalski jkowalski merged commit 3e8967c into kopia:main Oct 10, 2023
2 checks passed
@lupusA lupusA deleted the refactoring-themes branch October 19, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: the 'scheduled' label is too hard to read, at least when using the dark Kopia theme
2 participants