Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix out of sync situations while setting themes or font sizes #231

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

lupusA
Copy link
Collaborator

@lupusA lupusA commented Jan 14, 2024

Hi,

this PR fixes situations, where the theme or font size can get out of sync with the html class list.

  • Theme and font size is now set in one function
  • Class list elements are removed before they are set, preventing out of sync situations caused by replace elements
  • Minor refactorings

Cheers,

@lupusA lupusA merged commit 239b530 into kopia:main Jan 14, 2024
2 checks passed
@lupusA
Copy link
Collaborator Author

lupusA commented Jan 14, 2024

FYI @jkowalski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant