Don't break lines on curly quotes in Russian #577
Conversation
Many Russian texts are using quotes from Word (“”), so this rule leads to incorrect line breaks. It also isn't correct for Russian_En-US and Russian_En-GB variants.
|
Standard quotation marks are: |
|
@hius07, exactly. Despite being non-standard, these quotation marks are widely used. Also, when we have English words in the text, they can also use these quotes. |
This means that when standard quotes are used, you'll see If I trust my comment, I believe you should be fine: crengine/crengine/src/textlang.cpp Lines 1090 to 1095 in f6a17e6 Also don't just remove that line: just comment it out, with a small comment explaining why. |
|
@poire-z, I've added a comment and put back the commented out rule. Please let me know if it looks okay. |
|
Fine with your comment. |
Hmm, I tried building KOReader on my MacOS Sonoma (14.5) manually and via Docker, but both methods fail. Oh well. I'll need a volunteer to test this change or I can try fixing manual installation after I return from the vacation in 2 weeks. |
|
You mean building? |
|
Yes, building, @benoit-pierre. |
|
Did you follow the documentation? What was the issue exactly? Submodules make it a PITA, but you should be able to build a version with Github Actions: bump crengine in a custom koreader-base branch, push to Github, then bump base in a custom branch and push to Github after enabling actions. |
|
It was an error compiling I can just remove one line manually in the checkout out code, it's not a problem. |
|
Here's the corresponding build error, @benoit-pierre: |
|
For now, I suggest disabling building sdcv (the only glib user), by commenting the corresponding # sdcv
declare_project(thirdparty/sdcv DEPENDS glib zlib) |
|
Thanks, now it failed on the other step: |
|
It's weird you're having all those issues, the macos arm64 job on GA also uses 14.5, what's your xcode version? |
|
And please provide the beginning of the log: |
|
|
I'm missing the C/CXX compiler identification: please run |
|
And the xcode version ( |
As did I a few weeks ago. |
I tried |
|
CI: # xcode-select -p
/Applications/Xcode_15.0.1.app/Contents/Developer
# xcodebuild -version
Xcode 15.0.1
Build version 15A507 |
|
Relevant: actions/runner-images#10121. |
|
@benoit-pierre, I only have a CLI version installed: |
|
Never mind, I'll see if I can reproduce after bumping the XCode version. |
|
I seem to have 13.4.1 installed, which now refuses to start the GUI. I hadn't noticed because I only use the iPad/iPhone simulator directly, without Xcode in the way. You can't find out the version from |
This happens pretty much continuously btw. It's very unstable. |
|
Well, I'm hitting your first (glib) issue… |
|
I have a PR ready to switch to meson for some external projects, including glib. After that, we can look at updating glib. |
|
And for the libk2pdfopt issue: --- a/utils/gen_linker_exports.sh
+++ b/utils/gen_linker_exports.sh
@@ -13,7 +13,7 @@ shift 3
linker_version="$("${linker}" -v 2>&1)"
case "${linker_version}" in
- *PROJECT:ld64-* | *PROJECT:dyld-*)
+ *PROJECT:ld64-* | *PROJECT:dyld-* | *PROJECT:ld-*)
symarg='-u %s\n'
vsarg='-exported_symbols_list %s\n'
vsfmt='export' |
|
OK, merging, you'll all test that on your devices. |
|
I’ve tested it on my device while I was on vacation, and it works well. |
Many Russian texts are using quotes from Word (“”), so this rule leads to incorrect line breaks. It also isn't correct for Russian_En-US and Russian_En-GB variants, because English words are using these quotes extensively.
See the following screenshot, I've marked the hanging curly quote with red color. It should stay together on the next line with the word "маркий", but it's left hanging on the previous line instead.
@hius07, what do you think?
This change is