Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code and introduce rustfmt check in CI #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarijnS95
Copy link
Contributor

Hi! I'd love to start contributing to this crate, but one little annoyance is that it doesn't seem to use Rust's standard rustfmt autoformatter yet, and all code is out of sync. If there's no particular reason for that, I'd like to format the code and introduce a check in CI to ensure the code in the main branch as well as new code introduced by external contributors follows the same formatting guidelines.

@kornelski
Copy link
Owner

A while ago I've converted standalone functions to methods, and I wanted to keep the diff minimal to ensure I'm not changing anything else, and forgot to fix the formatting later.

@MarijnS95
Copy link
Contributor Author

All fine, that makes a lot of sense.

I was going to suggest using rustfmt config options to tweak it to make the changes less invasive but you've already done so on the main branch.

I don't understand the addition of disable_all_formatting = true though, that seems to be disabling most of the functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants