Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (devcontainer): setup devcontainer for vscode #206

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

johnnv1
Copy link
Member

@johnnv1 johnnv1 commented Dec 30, 2024

This pull request introduces a development container (devcontainer) setup for the project. The devcontainer configuration allows developers to have a consistent development environment using Visual Studio Code and Docker.

  • Consistent Development Environment: Ensures all developers work in the same environment, reducing "it works on my machine" issues.
  • Easy Setup: Simplifies the setup process for new contributors by providing a pre-configured development environment.
  • Enhanced Tooling: Includes useful VSCode extensions and tools to improve productivity and code quality.

Changes

  1. Devcontainer Configuration:

    • Added devcontainer.json file to define the development container settings.
    • The container uses the mcr.microsoft.com/devcontainers/rust:1-1 image, which includes Rust and its toolchain.
  2. Post Create Command:

    • Added postCreateCommand.sh script to install additional dependencies and tools after the container is created.
    • The script installs cmake, nasm, libgstreamer1.0-dev, libgstreamer-plugins-base1.0-dev, Just command runner, and UV for managing Python virtual environments.
  3. VSCode Customizations:

    • Configured VSCode extensions in the devcontainer.json to enhance the development experience:
      • rust-lang.rust-analyzer
      • streetsidesoftware.code-spell-checker
      • charliermarsh.ruff
      • Gruntfuggly.todo-tree
      • nefrob.vscode-just-syntax

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflict

- add devcontainer.json
- add postCreateCommand.sh
- update README.md
@johnnv1 johnnv1 requested a review from edgarriba December 31, 2024 13:21
@edgarriba edgarriba merged commit addf2c2 into kornia:main Dec 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants