Skip to content

Commit

Permalink
Added info about legal flow, trail and env name. Fixed skip of test t…
Browse files Browse the repository at this point in the history
…hat need AWS variables
  • Loading branch information
ToreMerkely committed Oct 11, 2024
1 parent 0f5d128 commit 181b8b0
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
5 changes: 4 additions & 1 deletion cmd/kosli/beginTrail.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ const beginTrailShortDesc = `Begin or update a Kosli flow trail.`
const beginTrailLongDesc = beginTrailShortDesc + `
You can optionally associate the trail to a git commit using ^--commit^ (requires access to a git repo). And you
can optionally redact some of the git commit data sent to Kosli using ^--redact-commit-info^`
can optionally redact some of the git commit data sent to Kosli using ^--redact-commit-info^.
A legal ^TRAIL-NAME^ must start with an alphanumeric and only contain alphanumeric characters, ^.^, ^-^, ^_^ and ^~^.
`

const beginTrailExample = `
# begin/update a Kosli flow trail:
Expand Down
2 changes: 2 additions & 0 deletions cmd/kosli/createEnvironment.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ it off again with the --exclude-scaling.
Logical environments are used for grouping of physical environments. For instance **prod-aws** and **prod-s3** can
be grouped into logical environment **prod**. Logical environments are view-only, you can not report snapshots
to them.
A legal ^ENVIRONMENT-NAME^ must start with an alphanumeric and only contain alphanumeric characters, ^.^, ^-^, ^_^ and ^~^.
`

const createEnvironmentExample = `
Expand Down
5 changes: 4 additions & 1 deletion cmd/kosli/createFlow.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ import (
const createFlowShortDesc = `Create or update a Kosli flow.`

const createFlowLongDesc = createFlowShortDesc + `
You can specify flow parameters in flags.`
You can specify flow parameters in flags.
A legal ^FLOW-NAME^ must start with an alphanumeric and only contain alphanumeric characters, ^.^, ^-^, ^_^ and ^~^.
`

const createFlowExample = `
# create/update a Kosli flow (with empty template):
Expand Down
7 changes: 5 additions & 2 deletions cmd/kosli/snapshotECS_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,11 @@ func (suite *SnapshotECSTestSuite) TestSnapshotECSCmd() {
golden: "Error: only one of --cluster, --clusters, --exclude-regex is allowed\n",
},
{
name: "snapshot ECS works if no filtering flags are used",
cmd: fmt.Sprintf(`snapshot ecs %s %s`, suite.envName, suite.defaultKosliArguments),
name: "snapshot ECS works if no filtering flags are used",
cmd: fmt.Sprintf(`snapshot ecs %s %s`, suite.envName, suite.defaultKosliArguments),
additionalConfig: snapshotECSTestConfig{
requireAuthToBeSet: true,
},
goldenRegex: "\\[\\d+\\] containers were reported to environment snapshot-ecs-env\n",
},
{
Expand Down

0 comments on commit 181b8b0

Please sign in to comment.