Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log error from flag assignment from env vars to standard errros #365

Merged
merged 4 commits into from
Oct 21, 2024
Merged

log error from flag assignment from env vars to standard errros #365

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca84961
ensure errors from env variable flag assignments are logged to standa…
sami-alajrami Oct 21, 2024
64b84cc
Merge branch 'main' into 362-fix-unprinted-error
sami-alajrami Oct 21, 2024
2b0493d
Merge branch 'main' into 362-fix-unprinted-error
sami-alajrami Oct 21, 2024
057d596
revert tests
sami-alajrami Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/kosli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ func initialize(cmd *cobra.Command, out io.Writer) error {
func bindFlags(cmd *cobra.Command, v *viper.Viper) {
// for some reason, logger does not print errors at the point
// of calling this function, so we ensure to point errors to stderr
logger.SetErrOut(cmd.ErrOrStderr())
logger.SetErrOut(os.Stderr)
// api token in config file is encrypted, so we have to decrypt it
// but if it is set via env variables, it is not encrypted
_, apiTokenSetInEnv := os.LookupEnv("KOSLI_API_TOKEN")
Expand Down
Loading