#74 Add environment to approvals #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t commit in seperate parameter
… their sha1 hashes
…instead of kosli command
ToreMerkely
approved these changes
Nov 29, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Add environment flag to reportApproval command * Approval: only send newest commit in commit list. Added sending oldest commit in seperate parameter * parse the input oldest and newset commit to verify they exist and get their sha1 hashes * Commands: add environment flag for request approval. * Updated approval documentation and CLI reference * Get oldest commit from kosli server if not given in command line * Remove newest_commit key from approval payload * Add test cases and fix typos in documentation * Approval: Updated URL. Started on some more tests * Create setup to make a snapshot in approval tests * Approval: calculate HEAD~5 in kosli approval command * Tests: calculate fingerprint of artifact for approval using function instead of kosli command * Delete dead comments * Update docs for approvals * Docs: fix typos * Approval: Small update docs --------- Co-authored-by: Tore Martin Hagen <[email protected]> Co-authored-by: Sami Alajrami <[email protected]> Co-authored-by: Arstanaly Rysbekov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.