Skip to content

port sniffer completed #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eoneoff wants to merge 4 commits into
base: master
Choose a base branch
from
Open

port sniffer completed #3

eoneoff wants to merge 4 commits into from

Conversation

@eoneoff
Copy link

@eoneoff eoneoff commented Oct 7, 2019

No description provided.

@AMashoshyna AMashoshyna added the port-sniffer Port sniffer task label Oct 15, 2019
maxborovsky
maxborovsky reviewed Oct 16, 2019
View reviewed changes
maxborovsky
maxborovsky reviewed Oct 16, 2019
View reviewed changes
@rekusha
Copy link

rekusha commented Dec 17, 2019

  1. --ports 80-80 don't see opened port
  2. must return 0 if programm is end correct

@eoneoff
Copy link
Author

eoneoff commented Dec 18, 2019

You can not say "is end". "Ends" or "is ending" or "is ended". "Ends" is the best option/

rekusha
rekusha approved these changes Dec 18, 2019
View reviewed changes
Copy link

@rekusha rekusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all work.
thx for correction about english

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxborovsky maxborovsky maxborovsky left review comments

+1 more reviewer

@rekusha rekusha rekusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

port-sniffer Port sniffer task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eoneoff @rekusha @maxborovsky @AMashoshyna