remove cvk_command_combine in favor of cvk_event_combine #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjodinchr
force-pushed
the
pr/event-combine
branch
from
54a89af
to
fb87413
Compare
|
It can feel like a lot of change, but most of it is just code being moved around. It is passing the full CTS on Nvidia and Swiftshader on my side. |
rjodinchr
force-pushed
the
pr/event-combine
branch
from
fb87413
to
076caaf
Compare
rjodinchr
force-pushed
the
pr/event-combine
branch
from
076caaf
to
e3605c0
Compare
rjodinchr
force-pushed
the
pr/event-combine
branch
2 times, most recently
from
ed5185e
to
3cfd81b
Compare
rjodinchr
force-pushed
the
pr/event-combine
branch
from
3cfd81b
to
3c009e5
Compare
rjodinchr
force-pushed
the
pr/event-combine
branch
from
3c009e5
to
0972333
Compare
cvk_command_combine prevents optimization where commands could be batch. It is needed to have a single event representing the execution of the group of commands. This PR creates a new event (cvk_event_combine) which allows to have a single event grouping several events, thus keeping the single event for the group of commands. It also allows to make do_action a private function, thus having it called only in one place. This is very convenient to implement future optimization (using VkSemaphore).
rjodinchr
force-pushed
the
pr/event-combine
branch
from
0972333
to
f7a7040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cvk_command_combine prevents optimization where commands could be batch.
It is needed to have a single event representing the execution of the group of commands. This PR creates a new event (cvk_event_combine) which allows to have a single event grouping several events, thus keeping the single event for the group of commands.
It also allows to make do_action a private function, thus having it called only in one place. This is very convenient to implement future optimization (using VkSemaphore).