-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address short comings with printf for strings #715
base: main
Are you sure you want to change the base?
Conversation
Next step is to add some unit tests |
Co-authored-by: Romaric Jodin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you only modify what really needs to change.
Co-authored-by: Romaric Jodin <[email protected]>
Co-authored-by: Romaric Jodin <[email protected]>
This is fixing CTS We should maybe try to address everything ( |
current status 3 sub-subtests are still failing. One which is due to some issue with printf itself. I.e. in strings subtest there is a subtest
is printing out
which is a bit confusing since the two %% should be consumed as one. also in the same subtests for
the kernel descriptors are not properly populated for some reason. a vector sub-subtest is also failing |
Co-authored-by: Romaric Jodin <[email protected]>
@kpet to get this PR working correctly we need to update clspv with the fixes landed by David |
Co-authored-by: Romaric Jodin <[email protected]>
This change fixes short comings encountered in 9 tests of the OpenCL-CTS as mentioned in issue #714 we still need to fix kernel descriptors.