Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle concurrent printf #725

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Handle concurrent printf #725

wants to merge 7 commits into from

Conversation

Rekt3421
Copy link
Contributor

@Rekt3421 Rekt3421 commented Oct 8, 2024 •
edited
Loading

This change moves the printf buffer from the queue to the kernel to resolve the issue of concurrent printf not printing properly . Please see #578 bullet 4

rjodinchr
rjodinchr reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@rjodinchr rjodinchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think testing that in the CI is too complicated as it depends on the performance of the hardware.
You can remove that test for now.

src/queue.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjodinchr rjodinchr rjodinchr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rekt3421 @rjodinchr