Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a new Django project #19

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

Martolivna
Copy link
Collaborator

@Martolivna Martolivna commented May 3, 2023

This patch adds a collection of settings for an instance of Django, including database configuration, Django-specific options, and application-specific settings.

Related to #16

@Martolivna Martolivna force-pushed the features/16-create-django-project branch 2 times, most recently from 9a53521 to 083a290 Compare May 3, 2023 19:16
@Martolivna
Copy link
Collaborator Author

It has only one commit with so many changes, but it must be together to work.

@Martolivna Martolivna requested a review from webknjaz May 3, 2023 19:39
@Martolivna Martolivna force-pushed the features/16-create-django-project branch from 083a290 to 1738aea Compare May 3, 2023 19:44
@webknjaz
Copy link
Member

webknjaz commented May 3, 2023

Resolves #16

Make it a reference without a keyword since this PR does not fully solve said issue and we don't need GitHub to automatically close it on merge.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great start, though I've got some comments for you below. Please, iterate on them.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
mysite/__init__.py Outdated Show resolved Hide resolved
mysite/asgi.py Outdated Show resolved Hide resolved
mysite/settings.py Outdated Show resolved Hide resolved
mysite/settings.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
mysite/settings.py Outdated Show resolved Hide resolved
mysite/wsgi.py Outdated Show resolved Hide resolved
mysite/urls.py Outdated Show resolved Hide resolved
mysite/settings.py Outdated Show resolved Hide resolved
@Martolivna Martolivna force-pushed the features/16-create-django-project branch 4 times, most recently from 8da1ce9 to 407903a Compare July 29, 2023 19:08
@Martolivna Martolivna requested a review from webknjaz July 29, 2023 19:12
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mysite/__init__.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
test_requirements.txt Outdated Show resolved Hide resolved
@Martolivna Martolivna force-pushed the features/16-create-django-project branch 5 times, most recently from a866d8b to c32a591 Compare August 1, 2023 20:25
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mysite/__init__.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mysite/__init__.py Outdated Show resolved Hide resolved
mysite/__init__.py Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Aug 4, 2023

@Martolivna I've completed a new round of reviews. As a bonus task, you can also create an extra
requirements/README.md file describing how to update those lockfiles/constraints using pip-tools. GitHub renders README files not only in the root folder of repositories but also in subdirectories, when people navigate there, using web interface.

@Martolivna Martolivna force-pushed the features/16-create-django-project branch from c32a591 to 6791bbf Compare August 16, 2023 17:40
README.md Outdated Show resolved Hide resolved
@Martolivna Martolivna force-pushed the features/16-create-django-project branch from bc7ccad to 159ffd3 Compare August 21, 2023 14:30
README.md Outdated Show resolved Hide resolved
@Martolivna Martolivna force-pushed the features/16-create-django-project branch 2 times, most recently from 6711d95 to 8297019 Compare August 21, 2023 19:28
This commit adds a collection of settings for an instance of Django, including
database configuration, Django-specific options, and
application-specific settings.

Ref #16
@Martolivna Martolivna force-pushed the features/16-create-django-project branch from 8297019 to fef8570 Compare August 21, 2023 19:29
@Martolivna Martolivna merged commit c1ce6b3 into main Aug 21, 2023
4 checks passed
@Martolivna Martolivna deleted the features/16-create-django-project branch August 21, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants