Create a blog Django app #20
Conversation
webknjaz
requested review from
OlenaYefymenko,
slsh1o,
serhii73 and
l1storez
|
@Martolivna, PR looks correct, taking into account this step https://tutorial.djangogirls.org/en/django_models/. |
|
@OlenaYefymenko publish your review |
There was a problem hiding this comment.
@Martolivna, PR looks correct, taking into account this step https://tutorial.djangogirls.org/en/django_models/.
I've added some minor comments. However, it would be better to provide a more detailed description of the PR, 1–2 sentences about models and migration.
As far as I know, the next step will be adding test, so it's would be better to clarify each part of PR.
| # VS Code | ||
| .vscode | ||
|
|
There was a problem hiding this comment.
There are a few problems here:
- Ignoring VS Code is usually more involved and includes allow-listing certain config files that are supposed to be checked into Git: https://www.toptal.com/developers/gitignore/api/visualstudiocode
- Editor-specific ignores are considered out of the scope in individual repos and are typically recommended to be managed through user-global exclusions: https://sebastiandedeyne.com/setting-up-a-global-gitignore-file
- Finally, changing Git configurations that are not directly related to the topic of the PR, make it non-atomic. So they must be excluded from the patch and submitted as separate PRs should the need be.
| from django.utils import timezone | ||
|
|
||
|
|
||
| class Post(models.Model): |
There was a problem hiding this comment.
@Martolivna I want you to write tests for this model.
Create a tests/test_models.py file, import this model there, follow https://docs.djangoproject.com/en/4.2/topics/testing/overview/ to declare a test case class and make dedicated methods for every separate thing/aspect you're testing.
Generally, those tests would make an instance of this class and then, call its methods + check their return values or side effects.
Make sure to call every method you declared in this class.
Bonus: you can also integrate coverage reporting like so https://adamj.eu/tech/2019/04/30/getting-a-django-application-to-100-percent-coverage/.
This patch adds a blog app. The blog app contains a blog post model and related data base migrations, tests.
Ref #16