Add running tests as a separate job in GitHub Actions CI/CD #40
Conversation
|
update: it's not a final version, I try to find out how to run tests from the directory |
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi |
There was a problem hiding this comment.
This shouldn't be conditional. This file should always be present. If it's not, that's a bug. If it's deleted from the repo accidentally, this should fail and not be skipped silently.
| python-version: ${{ matrix.python-version }} | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip |
There was a problem hiding this comment.
This is normally not necessary, unless you're facing specific issues. Also, try not to dump all the commands in a single step because it's harder to process the test job run report visually then.
| python-version: ["3.8", "3.9", "3.10"] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
It's a good idea to always specify the name. Just like with Ansible — it's the best practice.
.github/workflows/tests.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10"] |
There was a problem hiding this comment.
Also, while you're on it, please integrate yamllint with the following configuration:
- https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/master/.yamllint
- https://github.com/sphinx-contrib/sphinxcontrib-towncrier/blob/7588aed/.pre-commit-config.yaml#L119-L126
This will help you keep the style in the YAML files consistent. You can do this in a separate PR but an atomic commit in this one would be fine as well.
There was a problem hiding this comment.
fine, i try to do it
|
Maybe reference an issue this is related to? |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
What do you mean? Run tests from the directory? |
No, have useful text in the PR description. |
#27 The test should be as a separate job in the
ci.ymlor as a separate file?