NEW: generator hooks ✨ #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenein
force-pushed
the
new/generator-hooks
branch
2 times, most recently
from
b731ab9 to
3ecbe6f
Compare
|
This is quite complex to get your head around, do you think it deserves some mention in the docs/readme? |
eigenein
force-pushed
the
new/generator-hooks
branch
2 times, most recently
from
c7119fb to
865abe1
Compare
### Motivation I need to add some custom metric based on when exactly the decorated function got called: a background job start delay after its scheduled execution time. ### Implementation In addition to simple functions, the decorator now accepts generator functions. That would allow them to run some code just before the decorated function gets called and remember the state. Plain old hooks are not affected. The change is designed to be backwards-compatible.
eigenein
force-pushed
the
new/generator-hooks
branch
from
865abe1 to
f982302
Compare
|
Got verbal approvals, force-merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I need to add some custom metric based on when exactly the decorated function got called: a background job start delay after its scheduled execution time.
Implementation
In addition to simple functions, the decorator now accepts generator functions. That would allow them to run some code just before the decorated function gets called and remember the state.
Plain old hooks are not affected. The change is designed to be backwards-compatible.