NEW: support of async hooks #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss18
force-pushed
the
feature/DEP-2912-async-hooks
branch
2 times, most recently
from
4703c24 to
a7179ca
Compare
ss18
changed the title
ss18
force-pushed
the
feature/DEP-2912-async-hooks
branch
4 times, most recently
from
913e571 to
63f3347
Compare
ss18
changed the title
ss18
force-pushed
the
feature/DEP-2912-async-hooks
branch
3 times, most recently
from
1e5fef1 to
0aec83b
Compare
eigenein
reviewed
Jul 10, 2024
tests/test_hooks.py
Outdated
| assert metadata["async_global_hook"] == "async_global_hook value" | ||
| collector.clean() | ||
|
|
||
| assert True |
eigenein
previously approved these changes
Jul 10, 2024
ss18
force-pushed
the
feature/DEP-2912-async-hooks
branch
from
0aec83b to
cd3c8d1
Compare
eigenein
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of the py-timeexecution library lacks support for asynchronous hooks, which limits its applicability in modern asynchronous Python applications.
Implementation
Added TimedAsync which is async ContextManager. It can await hook if hook is an actual coroutine function.