More window improvements #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Matches software - Affects 200p and 400p
…lscreen - If you had one of these params on, the desired_fullscreen menu option would not work - Unlike these other params, -geom already allowed the menu option to work
|
What is the difference between 400p and 480p modes? 480p is stretched in the engine, but 400p is stretched by SDL? |
|
In my understanding, in 480p the vertical field of view is rendered to 480 pixels which are then transferred 1:1 to screen, whereas in 400p the vertical field of view is rendered to 400 pixels which are then stretched by factor 1.2:1 on their way to screen. |
|
Why do we need both 480p and 400p modes? They look very similar. I think we should pick the ones that look better and cut the rest. |
|
This clearly shows that 200p is the correct resolution, but it should be rendered in a 240p window, due to https://doomwiki.org/wiki/Aspect_ratio On 240p, some UI elements get screwed like this (only on software) On stretched 200p they look fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On software 200p and 400p, the image is stretched to match 240p and 480p. This makes OpenGL follow it
I meantioned before that I thought this behaviour should be removed instead, but Ive changed my opinions as I explored the issue more
If you had one of these params on, the desired_fullscreen menu option would not work
Unlike these other params, -geom already allowed the menu option to work
This is useful for the launcher, as it uses these params on every launch