Fix queries to consider role membership as well as table ownership #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the introspections that looked to see whether the current user owned a particular table only considered direct ownership. But in the case of a table owned by a role, any user that has that role also effectively owns the table, and has permission to operate on the table as if they were the direct owner. This change updates the get_referring_fks and is_table_owner introspection functions to consider both direct ownership and also indirect ownership via role membership.
Coverage Report Results
1 empty file skipped. |
marcelofern
reviewed
Jun 30, 2025
Collaborator
marcelofern
left a comment
marcelofern
left a comment
There was a problem hiding this comment.
Nice finding (-:
This deserves some tests though
s-cooper18
reviewed
Jun 30, 2025
s-cooper18
left a comment
s-cooper18
left a comment
There was a problem hiding this comment.
I agree with tests being useful for this
s-cooper18
approved these changes
Jul 1, 2025
s-cooper18
left a comment
s-cooper18
left a comment
There was a problem hiding this comment.
Tested changes locally - adding more thorough test ideal in long term, but for short term this is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the introspections that looked to see whether the current user owned a particular table only considered direct ownership. But in the case of a table owned by a role, any user that has that role also effectively owns the table, and has permission to operate on the table as if they were the direct owner.
This change updates the
get_referring_fksandis_table_ownerintrospection functions to consider both direct ownership and also indirect ownership via role membership.