Skip to content

refactor: use string.IsNullOrEmpty when checking for empty strings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kran27 merged 1 commit into from
Dec 10, 2024
Merged

refactor: use string.IsNullOrEmpty when checking for empty strings #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions VBLauncher/VB3DLib/VanBurenFormats.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ public TTextures(BinaryReader f, B3DModel b3d)
//Console.WriteLine("TTextures");
Unknown1 = f.ReadByte();
Name = StringRead(f);
if (b3d.texName == "") {b3d.texName = new string(Name);}
if (string.IsNullOrEmpty(b3d.texName)) {b3d.texName = new string(Name);}
FileName = StringRead(f);
Width = f.ReadUInt32();
Height = f.ReadUInt32();
Expand Down Expand Up @@ -798,8 +798,7 @@ private void ReadG3D(string[] f)
{
skipLine = false;
tmpList.AddRange(from ss in s.Split(" Triangles{Index( ")[1].Split(" ")
where ss != ""
select int.Parse(ss));
where !string.IsNullOrEmpty(ss) select int.Parse(ss));
}
else if (!skipLine)
{
Expand All @@ -809,8 +808,7 @@ private void ReadG3D(string[] f)
s = s.Split(" ) Edge( ")[0];
}
tmpList.AddRange(from ss in s.Split(" ")
where ss != ""
select int.Parse(ss));
where !string.IsNullOrEmpty(ss) select int.Parse(ss));
}
}
//split tmplist into groups of 3 and add to faces
Expand Down
Loading