Skip to content

Commit

Permalink
fix: add missing hook-deletion-policy to prevent installation error a…
Browse files Browse the repository at this point in the history
…fter failure (#101)
  • Loading branch information
matteogastaldello authored Jan 22, 2025
1 parent 52be7c3 commit 9d00bea
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion chart/templates/genCerts-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": pre-install, pre-upgrade
"helm.sh/hook-weight": "2"
"helm.sh/hook-delete-policy": hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
spec:
template:
spec:
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/genCertsScript-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": pre-install, pre-upgrade, post-install, post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
data:
create-certs.sh: |-
#! /bin/bash
Expand Down
4 changes: 2 additions & 2 deletions chart/templates/job-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": pre-install, pre-upgrade, post-install, post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand All @@ -21,7 +21,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": pre-install, pre-upgrade, post-install, post-upgrade
"helm.sh/hook-weight": "1"
"helm.sh/hook-delete-policy": hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/patchCRD-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
# job is considered part of the release.
"helm.sh/hook": post-install,post-upgrade
"helm.sh/hook-weight": "5"
"helm.sh/hook-delete-policy": hook-succeeded
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
spec:
template:
spec:
Expand Down

0 comments on commit 9d00bea

Please sign in to comment.