Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filling in a form, return key should submit. This includes login forms.
This took some doing, as the versions in the frontend weren't pinned down enough to allow setting up the environment easily. I used node 0.10.26 as suggested by .node-version, but the newer versions of some of the JS libraries don't like older node, so I swapped to a more conservative versioning specification for all libraries (~ vs ^). Also added two libraries that weren't present and required specific versions to be pinned.
For some reason the versions I have installed compile a slightly different bundle, but I don't care enough to figure out the magic combo to make it be seamless. @krister1028 do you want me to hard pin to what I have right now? In the last commit I noted that dedupe works. That means you can install exactly one version of every library, the dependencies are consistent.