Generalize handling WHERE IN clauses #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s now using the same mechanism as `Where` and isn’t constrained to string values anymore. Quoting and escaping is deferred to gocql, making the functionality more generally usable.
annismckenzie
changed the title
WhereIn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the changes I made in #3. It pushes clauses for
WHERE col IN (?)statements into the where clause handler, thereby drops the string value constraint and then lets gocql fill in the values correctly interpolated and escaped.If you want I can get started on a few basic tests – however, I've been using
WHERE INextensively in our codebase and the changes are sufficiently easy to understand.