feat: add extension field merkle tree mmcs #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
force-pushed
the
feat/add-extension-field-merkle-tree-mmcs
branch
2 times, most recently
from
5fafb54
to
ea411a0
Compare
chokobole
force-pushed
the
feat/add-extension-field-merkle-tree-mmcs
branch
from
ea411a0
to
88e1913
Compare
chokobole
force-pushed
the
feat/add-extension-field-merkle-tree-mmcs
branch
from
88e1913
to
5aef0be
Compare
ashjeong
reviewed
Jun 27, 2024
| @@ -12,13 +12,15 @@ namespace tachyon::math { | |||
|
|
|||
| template <typename T> | |||
| struct FiniteFieldTraits { | |||
| static constexpr bool kIsFiniteField = false; | |||
There was a problem hiding this comment.
Do we have a case in which a field would not be a finite field?
Comment on lines
+59
to
+61
| PackedPoseidon2 packed_sponge(packed_config); | ||
| MyPackedHasher packed_hasher(packed_sponge); | ||
| MyPackedCompressor packed_compressor(packed_sponge); |
There was a problem hiding this comment.
Can you std::move packed_config and packed_sponge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements ExtensionMMCS.