Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed parameters #17

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Renamed parameters #17

merged 1 commit into from
Nov 22, 2020

Conversation

krylovsk
Copy link
Owner

No description provided.

@krylovsk krylovsk merged commit dcc9f89 into master Nov 22, 2020
@krylovsk
Copy link
Owner Author

@mitjaziv FYI, I reviewed the parameters after merging your PRs and decided to rename them to make things a bit more explicit as the number of parameters grows. Also addressed golint issues (TBD running them in CI #13).

@krylovsk krylovsk deleted the feature/cleanup-parameters branch November 22, 2020 15:00
@mitjaziv
Copy link
Contributor

Looks better thank you and sorry for any inconvenience with naming and linters.

@krylovsk
Copy link
Owner Author

no worries, thanks for the contributions! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krylovsk @mitjaziv