Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Watterson's theta and Tajima's D into pixy #117

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

npb596
Copy link

@npb596 npb596 commented Aug 27, 2024

Hi Kieran!

Figured it's worth making this an official pull request by this point. Feel free to test or critique as needed.

Cheers,
Nick

@taprs
Copy link

taprs commented Sep 4, 2024

Cool to see it implemented Nick! Afaics these D values will be shifting depending on the amount of missing data unlike pi and Dxy, right? Should there maybe be a warning about that, e.g. to discourage comparisons of window D values in presence of missing data?

@npb596
Copy link
Author

npb596 commented Sep 5, 2024

Thanks Nikita! Yes to the shifting, and I've seen in my simulations my corrections for Watterson's theta and D are both still biased somewhat by missing data. I figured it's worth pushing this finally since it's still an improvement over several other tools. We're working on a manuscript that goes over caveats but I agree once this is implemented in the main pixy distro the documentation and code help messages should explicitly mention these issues too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants