-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Watterson's theta and Tajima's D into pixy #117
base: master
Are you sure you want to change the base?
Conversation
…old loop approach
Cool to see it implemented Nick! Afaics these D values will be shifting depending on the amount of missing data unlike pi and Dxy, right? Should there maybe be a warning about that, e.g. to discourage comparisons of window D values in presence of missing data? |
Thanks Nikita! Yes to the shifting, and I've seen in my simulations my corrections for Watterson's theta and D are both still biased somewhat by missing data. I figured it's worth pushing this finally since it's still an improvement over several other tools. We're working on a manuscript that goes over caveats but I agree once this is implemented in the main pixy distro the documentation and code help messages should explicitly mention these issues too. |
Hi Kieran!
Figured it's worth making this an official pull request by this point. Feel free to test or critique as needed.
Cheers,
Nick