Skip to content

Refactor/279/오늘의감정로딩UI추가 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SeokChan-Lee merged 6 commits into from
Apr 7, 2025
Merged

Refactor/279/오늘의감정로딩UI추가 #281

SeokChan-Lee merged 6 commits into from
Apr 7, 2025

Conversation

@SeokChan-Lee
Copy link
Collaborator

@SeokChan-Lee SeokChan-Lee commented Apr 7, 2025 •
edited
Loading

❓이슈

📝 Description

작업 내용
- 오늘의 감정(TodayMood) 컴포넌트 로딩 UI 추가
- 다중 클릭 방지겸 오버레이 형식으로 로딩 UI를 구성했습니다.
- 감정 선택이 다 끝나지 않았는데 로딩 UI가 조기 종료되어 useCreateEmotionLog에 await을 추가해줬습니다

  • 낙관적 업데이트 추가(w/찬기님)
    • 오늘의 감정 선택시 낙관적 업데이트를 적용하였습니다.
2025-04-07.4.36.22.mov

🌀 PR Type

어떤 변경 사항이 있나요?

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항 (오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

PR

  • Branch Convention 확인

    feat/* 기능 구현, fix/* 버그 수정, refactor/* 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

@SeokChan-Lee SeokChan-Lee added Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링 labels Apr 7, 2025
@SeokChan-Lee SeokChan-Lee requested a review from cksrlcks April 7, 2025 06:16
@SeokChan-Lee SeokChan-Lee self-assigned this Apr 7, 2025
@SeokChan-Lee SeokChan-Lee linked an issue Apr 7, 2025 that may be closed by this pull request
Refactor: 오늘의 감정 로딩 UI 추가 #279
Closed
1 task
@vercel
Copy link

vercel bot commented Apr 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
epigram-gilv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 7:35am

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Storybook URL: https://storybook-static-hgu2148v9-cksrlcks-projects.vercel.app

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Storybook URL: https://storybook-static-kunx2hohj-cksrlcks-projects.vercel.app

cksrlcks
cksrlcks reviewed Apr 7, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Storybook URL: https://storybook-static-julrh3hi4-cksrlcks-projects.vercel.app

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Storybook URL: https://storybook-static-l07522gyv-cksrlcks-projects.vercel.app

@SeokChan-Lee SeokChan-Lee force-pushed the Refactor/279/오늘의감정로딩UI추가 branch from 591e9bf to a7621b6 Compare April 7, 2025 07:34
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

Storybook URL: https://storybook-static-eq1gqkorl-cksrlcks-projects.vercel.app

cksrlcks
cksrlcks approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@cksrlcks cksrlcks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@SeokChan-Lee SeokChan-Lee merged commit 059e0bc into main Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cksrlcks cksrlcks cksrlcks approved these changes

Assignees

@SeokChan-Lee SeokChan-Lee

Labels

Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor: 오늘의 감정 로딩 UI 추가

3 participants

@SeokChan-Lee @cksrlcks