Improve StringArray write_to

firebolt/arrays/base.mojo

@@ -84,6 +84,10 @@ struct ArrayData(Copyable, Movable, Representable, Stringable, Writable):
             if self.dtype.native == known_type:
                 writer.write(self.buffers[0][].unsafe_get[known_type](index))
                 return
+        if self.dtype.is_string():
+            # Should print a StringArray through the element specific write_to.
+            writer.write("<str>")
+            return
         writer.write("dtype=")
         writer.write(self.dtype)
 

firebolt/arrays/binary.mojo

@@ -116,7 +116,14 @@ struct StringArray(Array):
 
         writer.write("StringArray( length=")
         writer.write(self.data.length)
-        writer.write(")")
+        writer.write(", data= [")
+        for i in range(self.data.length):
+            writer.write('"')
+            writer.write(self.unsafe_get((i)))
+            writer.write('", ')
+            if i > 1:
+                break
+        writer.write(" ])")
 
     fn __str__(self) -> String:
         return String.write(self)

firebolt/arrays/tests/test_binary.mojo

@@ -21,3 +21,8 @@ def test_string_builder():
 
     var s = a.unsafe_get(0)
     assert_equal(String(s), "hello")
+
+    assert_equal(
+        a.__str__().strip(),
+        'StringArray( length=2, data= ["hello", "world",  ])',
+    )

firebolt/dtypes.mojo

@@ -384,6 +384,10 @@ struct DataType(
     fn is_numeric(self) -> Bool:
         return self.is_integer() or self.is_floating_point()
 
+    @always_inline
+    fn is_string(self) -> Bool:
+        return self.code == STRING
+
     @always_inline
     fn is_list(self) -> Bool:
         return self.code == LIST