Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: support shared process namespace #149

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented Aug 6, 2024

Before starting the virtual machine, pay attention to the NamespaceMode setting of pid namespace in PodSandboxConfig. If it is set to "Pod", add task.share_pidns to the startup parameters of Kuasar's task.
When the task starts and detects the share_pidns parameter, create a pid ns when creating the shared namespace.
Since the pid ns needs to take effect on child processes, two forks are required. The process forked executes the pause function and does not exit anymore.

@wackxu wackxu requested a review from a team as a code owner August 6, 2024 03:40
Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burning1020 Burning1020 merged commit 182d7f8 into kuasar-io:main Aug 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants