wasm: add wasmtime support #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-von
force-pushed
the
support-wasmtime-outside
branch
2 times, most recently
from
1c8ea30 to
2ec01c6
Compare
Signed-off-by: Abel Feng <[email protected]>
The crate of "mach" which is indirectly dependence introduces by wasmtime-runtime, is in the license of BSD-2-Clause, we have to allow it, otherwise we can not use wasmtime. The Modified or New BSD (or BSD 3-clause) license is the same as BSD-2, but with an additional clause prohibiting the names of the authors from being used to endorse or promote products relating to the software. As BSD-3-Clause is allowed, we have to reason to deny BSD-2-Clause
otherwise some checks my get a name confliction error because some functions is implemented in different features, and annotated by the feature.
abel-von
force-pushed
the
support-wasmtime-outside
branch
from
2ec01c6 to
d20f428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support wasmtime as the wasm runtime for webassembly sandbox.
it use async feature of wasmtime and launch the instance inside the process, without forking a new process.
and the limit of memory is supported by wasmtime ResourceLimiter.
the cpu limitation of wasmtime is made by a "fuel" machanism and I am not sure how to make it follow the cpu quota limitation of containers. so cpu limitation is still not supported.