Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizing on fedora VM image #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeniferh
Copy link

Type of change

  • Optimization

Description

Cirros has limited usage so standardizing on Fedora, and we agreed 1Gi is a good min VM size

@jeniferh jeniferh requested review from a team as code owners February 12, 2025 21:48
@jeniferh
Copy link
Author

cc @ygalblum any concerns w/ this change?

@ygalblum
Copy link
Contributor

cc @ygalblum any concerns w/ this change?

I don't mind the move to fedora. I would maybe consider adding a parameter to the test to allow the user to change the image. But, not a must.

As for the RAM size. I guess the question is what are we testing here. If just the creation of VMs, will this pose a limit on the amount of VMs?

@jeniferh
Copy link
Author

I don't mind the move to fedora. I would maybe consider adding a parameter to the test to allow the user to change the image. But, not a must.

Hmm yeah good point, an image parameter would be nice.

As for the RAM size. I guess the question is what are we testing here. If just the creation of VMs, will this pose a limit on the amount of VMs?

Technically we only support min 512MB (https://access.redhat.com/articles/6571671) although we know Cirros can boot with less. It is a scheduling constraint, hmm again maybe a param is nice :)

@ygalblum
Copy link
Contributor

Technically we only support min 512MB (https://access.redhat.com/articles/6571671) although we know Cirros can boot with less. It is a scheduling constraint, hmm again maybe a param is nice :)

Yeah, I didn't want to say parameter twice :). But, even with a parameter, there should be a default value. Either 512Mi or 1Gi. Whatever you think is best.
BTW I added a simple way to pass values from kube-burner-ocp to kube-burner using a map instead of through environment variables: https://github.com/kube-burner/kube-burner/blob/79192395a592d516ae73d25bd94af514a060b14f/pkg/workloads/helpers.go#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants