Factor out formatting from codegen #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
since renovate does not contain rustfmt NOR rustup. Signed-off-by: clux <[email protected]>
Signed-off-by: clux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make it its own step because we cannot do it from renovate with shellouts because renovate does not have rustfmt.
(It also cannot easily be installed because renovate image is no sudo, and rustfmt is designed to be installed with rustup these days with no releases for manual install, and rustup is not installed in the image).
To make this less painful, and more sensible, we make cargo fmt an explicit last step of codegeneration and commit a small rustfmt rule file. No nightly this itme.