easy parts of code review

Signed-off-by: clux <[email protected]>
kube-rs · Nov 16, 2021 · ff2cfe4 · ff2cfe4
1 parent f5063a7
commit ff2cfe4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 18 deletions.
diff --git a/examples/configmapgen_controller.rs b/examples/configmapgen_controller.rs
@@ -122,13 +122,6 @@ async fn main() -> Result<()> {
         }
     });
 
-    //let w = kube::runtime::watcher(cmgs, Default::default());
-    //let mut ap = kube::runtime::utils::try_flatten_applied(w).boxed();
-    //use futures::TryStreamExt;
-    //while let Some(x) = ap.try_next().await? {
-    //    println!("success {}", x.meta().clone().name.unwrap_or_default());
-    //}
-
     Controller::new(cmgs, ListParams::default())
         .owns(cms, ListParams::default())
         .reconcile_all_on(reload_rx.map(|_| ()))

diff --git a/kube-runtime/src/observer.rs b/kube-runtime/src/observer.rs
@@ -36,15 +36,6 @@ where
     backoff: Option<ExponentialBackoff>,
 }
 
-impl<K> From<Api<K>> for Observer<K>
-where
-    K: Clone + Resource + DeserializeOwned + Debug + Send + Sync + 'static,
-{
-    fn from(api: Api<K>) -> Observer<K> {
-        Observer::new(api)
-    }
-}
-
 impl<K> Observer<K>
 where
     K: Clone + Resource + DeserializeOwned + Debug + Send + Sync + 'static,

diff --git a/kube-runtime/src/watcher.rs b/kube-runtime/src/watcher.rs
@@ -244,11 +244,11 @@ pub fn watcher<K: Resource + Clone + DeserializeOwned + Debug + Send + 'static,
             let (event, state) = step(&api, &list_params, state).await;
             if event.is_err() {
                 if let Some(wait_time) = backoff.next_backoff() {
-                    tracing::debug!("watch waiting {}ms until retrying", wait_time.as_millis()); // TODO: kind name here
+                    tracing::debug!("watcher waiting {}ms until retrying", wait_time.as_millis()); // TODO: kind name here
                     tokio::time::sleep(wait_time).await;
                     Some((Err(Error::BackoffRetriable), (api, list_params, backoff, state)))
                 } else {
-                    tracing::warn!("watch cancelled, strategy returned none");
+                    tracing::warn!("watcher cancelled, strategy returned none");
                     None
                 }
             } else {