-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to hyper 1 #1438
update to hyper 1 #1438
Conversation
52a8c5d
to
85c9ee1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
=======================================
- Coverage 72.2% 72.1% -0.1%
=======================================
Files 78 78
Lines 6546 6594 +48
=======================================
+ Hits 4722 4749 +27
- Misses 1824 1845 +21
|
Signed-off-by: tottoto <[email protected]>
85c9ee1
to
f6edd39
Compare
Signed-off-by: tottoto <[email protected]>
cace5f5
to
8118092
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my god! thank you so much for doing this. you are a hero.
i could not for the life of me figure out what to do with Body
, but it's relieving to see that with the one you added in body.rs
everything mostly falls into place.
Was stress testing this a bit this morning and not able to break anything that was not already broken. So, in short, I am just going to merge this; it manages to do this monumental upgrade while providing minimal breaking changes:
I expect we will need some follow-ups here to move onto less |
Adding my thanks to @clux this will be extremely helpful! |
Resolves #1351.