Add ObjectRef::from as alias for ::from_obj #1598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows things that rely on
From
/Into
to perform the conversion implicitly. For example, we (@stackabletech) useObjectRef
s to normalize object path formatting in errors. When using SNAFU, this would simplify the error annotations from:to:
Solution
The
From
impl just delegates to::from_obj()
. Maybe it would even make sense to deprecate::from_obj
, but I think it makes sense to keep it to highlight it as a first-class operation.