Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to hashbrown 0.15.0 #1599

Merged
merged 1 commit into from
Oct 11, 2024
Merged

upgrade to hashbrown 0.15.0 #1599

merged 1 commit into from
Oct 11, 2024

Conversation

rorosen
Copy link
Contributor

@rorosen rorosen commented Oct 10, 2024

Hashbrown 0.15.0 has reworked the entry API which requires the use of a raw entry builder to replace keys.

Closes #1597

Motivation

Upgrade to hashbrown 0.15.0

Solution

As a result of a reworked entry API in hashbrown 0.15.0, we cannot longer use the replace_key() function to replace an entry's key directly. This uses a raw entry builder for the HashMap instead.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2%. Comparing base (2c97edd) to head (dd482eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1599   +/-   ##
=====================================
  Coverage   75.2%   75.2%           
=====================================
  Files         82      82           
  Lines       7336    7336           
=====================================
  Hits        5514    5514           
  Misses      1822    1822           
Files with missing lines Coverage Δ
kube-runtime/src/scheduler.rs 94.8% <100.0%> (ø)

@rorosen rorosen marked this pull request as draft October 10, 2024 08:17
Hashbrown 0.15.0 has reworked the entry API which requires the use of a
raw entry builder to replace keys.

Signed-off-by: Robert Rose <[email protected]>
@rorosen rorosen marked this pull request as ready for review October 10, 2024 09:32
@rorosen
Copy link
Contributor Author

rorosen commented Oct 10, 2024

hashbrown 0.15.0 also changed the default hasher from ahash to foldhash which uses the zlib license. However, it is approved for allowlist by cncf, so I added it to the allowlist.

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks a lot for this. Generally seems sensible, one quick Q.

kube-runtime/src/scheduler.rs Show resolved Hide resolved
deny.toml Show resolved Hide resolved
@clux clux added this to the 0.97.0 milestone Oct 10, 2024
@clux clux added dependencies upgrades to dependencies changelog-change changelog change category for prs labels Oct 10, 2024
@clux clux merged commit 2280962 into kube-rs:main Oct 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to hashbrown 0.15.0
2 participants