-
Notifications
You must be signed in to change notification settings - Fork 50
enable codespell via github workflow, and corresponding typo fixes. #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomoya.Fujita <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @fujitatomoya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the overall quality and consistency of the repository's textual content by integrating Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces codespell
to the project's workflow and applies numerous typo fixes across various documentation and configuration files. This is a valuable addition for maintaining code and documentation quality. My review focuses on enhancing the codespell
configuration for better coverage and points out a few remaining typos and grammatical errors that were missed during the initial sweep.
sig-robotics/examples/Implement-VSLAM-algorithm-based-on-KubeEdge/build/ros-melodic/README.md
Outdated
Show resolved
Hide resolved
...sal/Definition of cloud robot CRD and Operator/Definition of cloud robot CRD and Operator.md
Outdated
Show resolved
Hide resolved
sig-robotics/proposal/Implement-VSLAM-algorithm-based-on-KubeEdge/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoya.Fujita <[email protected]>
@@ -0,0 +1,21 @@ | |||
name: codespell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure why github workflow is started, is there any specific repo setting that disables the workflows?
closes #230