Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pr of multi robot simulation #94

Closed
wants to merge 7 commits into from
Closed

add pr of multi robot simulation #94

wants to merge 7 commits into from

Conversation

buptwjf
Copy link
Contributor

@buptwjf buptwjf commented Aug 1, 2022

Signed-off-by: buptwjf [email protected]
Add proposal for Simulation-of-multi-robot-cooperation-based-on-KubeEdge
issues
kubeedge/examples#119

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2022
@JoeyHwong-gk
Copy link
Contributor

Suggests:

  1. Follow here to signed off for each commits.
  2. Please details what robots will be use, and what's the roles of them.
  3. Please details all your components and how they interact.

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2022
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
fisherxu
fisherxu reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dir proposal should be proposals.
The dir Simulation-of-multi-robot-cooperation-based-on-KubeEdge is too long, simulation-of-multi-robot-cooperation is enough?

@buptwjf
Update proposal
782beb8 
Add proposal details
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buptwjf @kubeedge-bot @JoeyHwong-gk @fisherxu