[proposal] Edgemesh Container Network supports CNI features #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
size/XXL
kubeedge-bot
added
the
needs-rebase
|
@IdeaMeshDyx Need fix conflict |
kubeedge-bot
added
size/L
Poorunga
reviewed
Oct 30, 2023
cmd/edgemesh-agent/app/server.go
Outdated
| @@ -2,6 +2,7 @@ package app | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/kubeedge/edgemesh/pkg/cni" | |||
There was a problem hiding this comment.
go import顺序请遵守如下规范：
- 内置包
- 第三方包
- 项目自身的包
用空行间隔
|
CI / Check helm package (pull_request) Failing 一直出错的原因是，你自己生成的edgemsh.tgz 文件和 github自动生成的tgz，md5不一致 @IdeaMeshDyx 建议先不要改动build/helm目录下的文件 |
|
@IdeaMeshDyx 需要执行 ./hack/verify-vendor.sh 和 ./hack/update-vendor.sh 和 ./hack/update-vendor-licenses.sh 去更新vendor和licenses |
Poorunga
reviewed
Oct 31, 2023
go.mod
Outdated
| @@ -37,6 +35,11 @@ require ( | |||
| sigs.k8s.io/yaml v1.2.0 | |||
| ) | |||
|
|
|||
| require ( | |||
Poorunga
reviewed
Oct 31, 2023
pkg/cni/adapter.go
Outdated
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/kubeedge/edgemesh/pkg/apis/config/defaults" |
Poorunga
reviewed
Oct 31, 2023
pkg/util/cni/tun.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/songgao/water" |
IdeaMeshDyx
force-pushed
the
cni
branch
2 times, most recently
from
14aa5c6 to
44a243e
Compare
Signed-off-by: ideameshdyx <[email protected]>
Signed-off-by: ideameshdyx <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Poorunga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
What this PR does / why we need it:
This proposal provides a design for edgemesh to support CNI feature.
There are two main goals:
Implement network partitioning and container IP allocation functions, compatible with CNI standards, and ensure that the IP address of each container in the cluster is unique.
Support cross-subnet Pod IP traffic proxy and forwarding functions, compatible with CNI standards.
Which issue(s) this PR fixes:
Fixes #465