add metrics for libp2p #506
Conversation
kubeedge-bot
added
the
size/XXL
|
@wuming333666 You need add sign-off in your commits. Refer to https://github.com/kubeedge/edgemesh/pull/506/checks?check_run_id=17554341863 |
pkg/tunnel/module.go
Outdated
| @@ -3,6 +3,8 @@ package tunnel | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| rcmgr "github.com/libp2p/go-libp2p/p2p/host/resource-manager" | |||
There was a problem hiding this comment.
Golang package import order:
- Built-in
- Third parties
- Project related
Otherwise CI will fail.
|
@wuming333666 Hi, How should I contact you? Are you willing to share your contact information? Such as email or WeChat？ |
my email is [email protected] |
pkg/tunnel/tunnel.go
Outdated
| "k8s.io/apimachinery/pkg/util/wait" | ||
| "k8s.io/klog/v2" | ||
| "sigs.k8s.io/yaml" | ||
|
|
||
| ocprom "contrib.go.opencensus.io/exporter/prometheus" |
There was a problem hiding this comment.
move pkg ocprom to third-part pkg zoom
Signed-off-by: cjw <[email protected]>
Signed-off-by: cjw <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Poorunga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
What type of PR is this?
/kind design
What this PR does / why we need it:
add libp2p metrics,
Helpful for troubleshooting
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: