Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml path fix #133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

octonawish-akcodes
Copy link

@octonawish-akcodes octonawish-akcodes commented Aug 14, 2024

This PR will fix the yaml path inconsistencies while testing the quickstart guide of ianvs. It fixes the pcb-aoi. https://ianvs.readthedocs.io/en/latest/guides/quick-start.html#step-3-ianvs-execution-and-presentation

@CreativityH @MooreZheng

Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
@MooreZheng
Copy link
Collaborator

Thank you @octonawish-akcodes your work is appreciated
It looks like the CI is failing and @hsj576 might take a look at it

Signed-off-by: Abhishek Kumar <[email protected]>
@fisherxu
Copy link
Member

/assign @MooreZheng

@fisherxu fisherxu closed this Aug 14, 2024
@fisherxu fisherxu reopened this Aug 14, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 14, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rerun the CI or close-reopen this PR to trigger CI again to fix fossa CI

@MooreZheng
Copy link
Collaborator

/assign @hsj576

@MooreZheng MooreZheng added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed documentation PR labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants