-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal of Personalized LLM Agent based on KubeEdge-Ianvs Cloud-Edge Collaboration #138
base: main
Are you sure you want to change the base?
Conversation
… Collaborative Lifelong Learning Signed-off-by: Frank-lilinjie <[email protected]>
Signed-off-by: Frank-lilinjie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is related to #128 . As discussed in the routine meeting, this PR is no longer related to lifelong learning, so the current version is fine as it is.
Here are some suggestions
- The personalized agent is designed, using specific domain data to finetune multiple agents. This should be indicated in the detailed design.
- The demo session shows a user flow, indicating how to use this technique, which is great. It will be appreciated with the user flow enriched, which could directly lead to further designs on APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hsj576 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Frank-lilinjie <[email protected]>
I'm going to write your suggestions about the APIs in the case of README. |
Signed-off-by: Frank-lilinjie <[email protected]>
Signed-off-by: Frank-lilinjie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great! As discussed on the meeting, the comparison example can be improved to made the motivation more vivid.
Signed-off-by: Frank-lilinjie <[email protected]>
/lgtm |
New changes are detected. LGTM label has been removed. |
Signed-off-by: QiaoZheyu <[email protected]> Update README.md Update CI badge modify proposal of LLM Agent Signed-off-by: Frank-lilinjie <[email protected]> :modify the image of demo Signed-off-by: Frank-lilinjie <[email protected]>
Signed-off-by: Frank-lilinjie <[email protected]>
…ud-Edge Collaboration Signed-off-by: Frank-lilinjie <[email protected]>
…aboration.md Signed-off-by: Frank-lilinjie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a CI issue remains to be resolved
``Run` pylint '/home/runner/work/ianvs/ianvs/core'
************* Module core.testcasecontroller.algorithm.paradigm.singletask_learning.singletask_learning_active_boost
core/testcasecontroller/algorithm/paradigm/singletask_learning/singletask_learning_active_boost.py:66:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
************* Module core.testenvmanager.dataset.dataset
core/testenvmanager/dataset/dataset.py:119:4: R0917: Too many positional arguments (8/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:206:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:213:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:246:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:285:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:329:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
core/testenvmanager/dataset/dataset.py:368:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments)
Your code has been rated at 9.95/10
Error: Process completed with exit code 8.``
Personalized LLM Agent based on KubeEdge-Ianvs Cloud-Edge Collaboration