-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSPP: Implementation of Domain-Specific Large Model Benchmarking Based on KubeEdge-Ianvs #144
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "print" in the code should be replaced by "LOGGER.info" (from core.common.log import LOGGER ").
Signed-off-by: IcyFeather <[email protected]>
@hsj576 Thank you for your advice! Now they are all replaced. |
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebases are needed.
-
There is a file with conflicts like docs/proposals/scenarios/llm-benchmarks/llm-benchmarks.md that needs to take care of. e.g., using rebase https://liwt31.github.io/2019/12/25/merge_rebase/.
-
all commits need sign-off, which can also be solved by using rebase
Commit sha: 9b7f9c5, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.
Commit sha: ce9f470, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.
To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~11 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin dev
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebases are needed.
- There is a file with conflicts like docs/proposals/scenarios/llm-benchmarks/llm-benchmarks.md that needs to take care of. e.g., using rebase https://liwt31.github.io/2019/12/25/merge_rebase/.
- all commits need sign-off, which can also be solved by using rebase
Commit sha: 9b7f9c5, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.
Commit sha: ce9f470, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~11 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin dev
Reminder: There are three CI issues that remain to be resolved, mainly for Pylint, see https://github.com/kubeedge/ianvs/actions/runs/11268242806
@MooreZheng The similar pylint issues are described in #152 To solve this, sedna and ianvs need to corporate. We discussed this problem in the last week zoom meeting, and it seems that it should be discussed more to find a final solution. |
This PR is the implementation of #95