Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPP: Implementation of Domain-Specific Large Model Benchmarking Based on KubeEdge-Ianvs #144

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

IcyFeather233
Copy link

This PR is the implementation of #95

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2024
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "print" in the code should be replaced by "LOGGER.info" (from core.common.log import LOGGER ").

@IcyFeather233
Copy link
Author

The "print" in the code should be replaced by "LOGGER.info" (from core.common.log import LOGGER ").

@hsj576 Thank you for your advice! Now they are all replaced.

IcyFeather added 2 commits September 19, 2024 16:52
Signed-off-by: IcyFeather <[email protected]>
Signed-off-by: IcyFeather <[email protected]>
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebases are needed.

  1. There is a file with conflicts like docs/proposals/scenarios/llm-benchmarks/llm-benchmarks.md that needs to take care of. e.g., using rebase https://liwt31.github.io/2019/12/25/merge_rebase/.

  2. all commits need sign-off, which can also be solved by using rebase

Commit sha: 9b7f9c5, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.
Commit sha: ce9f470, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~11 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin dev

@kubeedge-bot kubeedge-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign moorezheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @moorezheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

IcyFeather added 2 commits September 23, 2024 18:37
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebases are needed.

  1. There is a file with conflicts like docs/proposals/scenarios/llm-benchmarks/llm-benchmarks.md that needs to take care of. e.g., using rebase https://liwt31.github.io/2019/12/25/merge_rebase/.
  2. all commits need sign-off, which can also be solved by using rebase

Commit sha: 9b7f9c5, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.
Commit sha: ce9f470, Author: IcyFeather, Committer: IcyFeather; The sign-off is missing.

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~11 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin dev

Reminder: There are three CI issues that remain to be resolved, mainly for Pylint, see https://github.com/kubeedge/ianvs/actions/runs/11268242806

@IcyFeather233
Copy link
Author

@MooreZheng The similar pylint issues are described in #152

To solve this, sedna and ianvs need to corporate. We discussed this problem in the last week zoom meeting, and it seems that it should be discussed more to find a final solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants