Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usbcamera-dmi #122

Merged
merged 1 commit into from
Jan 19, 2024
Merged

add usbcamera-dmi #122

merged 1 commit into from
Jan 19, 2024

Conversation

luomengY
Copy link
Member

@luomengY luomengY commented Dec 6, 2023

A USB protocol camera mapper developed based on the dmi and mapper framework.
@cl2017 @wbc6080

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 6, 2023
@luomengY luomengY force-pushed the usbcamera-dmi branch 4 times, most recently from 4d25fd4 to 1141f60 Compare December 6, 2023 05:46
@wbc6080
Copy link
Collaborator

wbc6080 commented Dec 8, 2023

Is the vendor folder necessary? Can we use go.mod directly? Otherwise, there will be too many files and review will be difficult

@luomengY luomengY force-pushed the usbcamera-dmi branch 2 times, most recently from 66709a8 to e84f5d8 Compare December 8, 2023 09:36
@luomengY
Copy link
Member Author

luomengY commented Dec 8, 2023

Is the vendor folder necessary? Can we use go.mod directly? Otherwise, there will be too many files and review will be difficult

ok, I have deleted the vendor.

@luomengY luomengY force-pushed the usbcamera-dmi branch 19 times, most recently from 92c1364 to ebd8962 Compare December 26, 2023 01:30
@wbc6080
Copy link
Collaborator

wbc6080 commented Jan 19, 2024

Would it be better to change the directory name to mappers/kubeedge-v1.15.0/usbcamera-dmi/... ?

@luomengY
Copy link
Member Author

kubeedge-v1.15.0

ok

Signed-off-by: luomengY <[email protected]>
@wbc6080
Copy link
Collaborator

wbc6080 commented Jan 19, 2024

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks for the mapper.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@kubeedge-bot kubeedge-bot merged commit 36cc3be into kubeedge:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants