Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

responsiveness of the Why KubeEdge section #395

Merged
merged 1 commit into from
Aug 7, 2023
Merged

responsiveness of the Why KubeEdge section #395

merged 1 commit into from
Aug 7, 2023

Conversation

nikhilchauhangithub
Copy link
Contributor

@nikhilchauhangithub nikhilchauhangithub commented Aug 6, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • [ x] The commit message follows our guidelines
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • [ x] Docs have been added / updated (for bug fixes / features)

made "Why KubeEdge section" responsive, initially it was not responsive
issue #385

before
localhost_3000_(iPhone 12 Pro) (1)

after
localhost_3000_(iPhone 12 Pro)

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2023
@nikhilchauhangithub
Copy link
Contributor Author

@kevin-wangzefeng @Shelley-BaoYue @fisherxu this looks more professional and now is responsive, kindly review it, i am open for changes

@kevin-wangzefeng
Copy link
Member

Thanks for the PR, it looks great to me.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@kubeedge-bot kubeedge-bot merged commit 9c0619e into kubeedge:master Aug 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@Shelley-BaoYue Shelley-BaoYue Awaiting requested review from Shelley-BaoYue

Assignees

@kevin-wangzefeng kevin-wangzefeng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilchauhangithub @kevin-wangzefeng @kubeedge-bot